From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: tracepoint: Avoid double static_branch evaluation at guarded call sites Date: Wed, 25 Mar 2026 07:48:30 +1000 Message-ID: In-Reply-To: <20260323160052.17528-1-vineeth@bitbyteword.org> References: <20260323160052.17528-1-vineeth@bitbyteword.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: tracepoint: Avoid double static_branch evaluation at guarded call = sites Author: "Vineeth Pillai (Google)" Patches: 6 Reviewed: 2026-03-25T07:48:30.130602 --- This is a well-motivated, straightforward optimization series. The core ide= a =E2=80=94 avoiding a redundant `static_branch_unlikely()` evaluation at g= uarded tracepoint call sites =E2=80=94 is sound and was explicitly requeste= d by Peter Zijlstra and Steven Rostedt. The implementation is clean: patch = 1 adds the new API in three locations within `tracepoint.h`, and the remain= ing patches are mechanical conversions. The mbox filtered to dri-devel contains the cover letter (0/19) plus patche= s 1/19, 5/19, 8/19, and 10/19. The conversion patches are straightforward a= nd correct. I have one concern about the API patch regarding the LOCKDEP as= sertion, and one minor observation about the commit message. --- Generated by Claude Code Patch Reviewer