Claude review: drm/ast: Clean up access to MMIO registers

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: drm/ast: Clean up access to MMIO registers
Author: Thomas Zimmermann <tzimmermann@suse.de>
Patches: 17
Reviewed: 2026-03-25T07:46:39.011091

---

This is a well-structured 15-patch cleanup series for the drm/ast driver by Thomas Zimmermann. It replaces hundreds of open-coded magic register addresses with named constants, consolidates the P2A bridge register access helpers, and fixes a real bug in patch 1. The series has been smoke-tested on AST2100, AST2300, AST2500, and AST2600.

The overall approach is sound - the driver was previously littered with raw hex addresses like `0x1e6e0000`, `0x1e6e2000`, etc., making the code hard to audit. The new `AST_REG_MCR*`, `AST_REG_SCU*`, `AST_REG_AHBC*`, etc. constants make register accesses self-documenting. The series is largely mechanical but done carefully, with a few substantive improvements (the new `ast_moutdwm_poll()` helper, the `ast_dramstruct` rework to use full 32-bit addresses).

I have a few concerns noted below but nothing that should block merging.

---
Generated by Claude Code Patch Reviewer