From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/ast: Clean up access to MMIO registers Date: Wed, 25 Mar 2026 07:46:39 +1000 Message-ID: In-Reply-To: <20260323160407.245773-1-tzimmermann@suse.de> References: <20260323160407.245773-1-tzimmermann@suse.de> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/ast: Clean up access to MMIO registers Author: Thomas Zimmermann Patches: 17 Reviewed: 2026-03-25T07:46:39.011091 --- This is a well-structured 15-patch cleanup series for the drm/ast driver by Thomas Zimmermann. It replaces hundreds of open-coded magic register addresses with named constants, consolidates the P2A bridge register access helpers, and fixes a real bug in patch 1. The series has been smoke-tested on AST2100, AST2300, AST2500, and AST2600. The overall approach is sound - the driver was previously littered with raw hex addresses like `0x1e6e0000`, `0x1e6e2000`, etc., making the code hard to audit. The new `AST_REG_MCR*`, `AST_REG_SCU*`, `AST_REG_AHBC*`, etc. constants make register accesses self-documenting. The series is largely mechanical but done carefully, with a few substantive improvements (the new `ast_moutdwm_poll()` helper, the `ast_dramstruct` rework to use full 32-bit addresses). I have a few concerns noted below but nothing that should block merging. --- Generated by Claude Code Patch Reviewer