From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/msm/a6xx: Add missing aperture_lock init
Date: Wed, 25 Mar 2026 07:43:57 +1000 [thread overview]
Message-ID: <review-overall-20260323161603.1165108-1-robin.clark@oss.qualcomm.com> (raw)
In-Reply-To: <20260323161603.1165108-1-robin.clark@oss.qualcomm.com>
Overall Series Review
Subject: drm/msm/a6xx: Add missing aperture_lock init
Author: Rob Clark <robin.clark@oss.qualcomm.com>
Patches: 4
Reviewed: 2026-03-25T07:43:57.609110
---
This is a single, straightforward one-liner bugfix that adds a missing `spin_lock_init()` for the `aperture_lock` spinlock in `struct a6xx_gpu`. The lock is declared in `a6xx_gpu.h:112` and actively used in `a8xx_gpu.c` (via `spin_lock_irqsave`/`spin_unlock_irqrestore`), but was never initialized. This is clearly a bug introduced when A8xx GPU support was added, and the fix is correct.
**Verdict: Patch looks good.** No issues found.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-03-24 21:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 16:16 [PATCH] drm/msm/a6xx: Add missing aperture_lock init Rob Clark
2026-03-23 17:42 ` Dmitry Baryshkov
2026-03-23 17:55 ` Akhil P Oommen
2026-03-24 9:23 ` Konrad Dybcio
2026-03-24 21:43 ` Claude review: " Claude Code Review Bot
2026-03-24 21:43 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260323161603.1165108-1-robin.clark@oss.qualcomm.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox