From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm/a6xx: Add missing aperture_lock init Date: Wed, 25 Mar 2026 07:43:57 +1000 Message-ID: In-Reply-To: <20260323161603.1165108-1-robin.clark@oss.qualcomm.com> References: <20260323161603.1165108-1-robin.clark@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/msm/a6xx: Add missing aperture_lock init Author: Rob Clark Patches: 4 Reviewed: 2026-03-25T07:43:57.609110 --- This is a single, straightforward one-liner bugfix that adds a missing `spin_lock_init()` for the `aperture_lock` spinlock in `struct a6xx_gpu`. The lock is declared in `a6xx_gpu.h:112` and actively used in `a8xx_gpu.c` (via `spin_lock_irqsave`/`spin_unlock_irqrestore`), but was never initialized. This is clearly a bug introduced when A8xx GPU support was added, and the fix is correct. **Verdict: Patch looks good.** No issues found. --- Generated by Claude Code Patch Reviewer