From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: accel/amdxdna: Return ERR_PTR on dma_alloc_noncoherent failure
Date: Wed, 25 Mar 2026 07:38:18 +1000 [thread overview]
Message-ID: <review-overall-20260323173719.2311474-1-lizhi.hou@amd.com> (raw)
In-Reply-To: <20260323173719.2311474-1-lizhi.hou@amd.com>
Overall Series Review
Subject: accel/amdxdna: Return ERR_PTR on dma_alloc_noncoherent failure
Author: Lizhi Hou <lizhi.hou@amd.com>
Patches: 4
Reviewed: 2026-03-25T07:38:18.945083
---
This is a single-patch bug fix for a real NULL-vs-ERR_PTR mismatch in the amdxdna driver. The fix is correct, minimal, and well-targeted. All four callers of `aie2_alloc_msg_buffer()` use `IS_ERR()` to check the return value, but the `dma_alloc_noncoherent()` path returns NULL on failure rather than an ERR_PTR. This means allocation failures on that path would slip past the error check, leading to a NULL pointer dereference. The patch properly converts the NULL to `ERR_PTR(-ENOMEM)`.
**Verdict: Good patch, should be accepted.**
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-24 21:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 17:37 [PATCH V1] accel/amdxdna: Return ERR_PTR on dma_alloc_noncoherent failure Lizhi Hou
2026-03-23 17:53 ` Karol Wachowski
2026-03-23 17:56 ` Mario Limonciello (AMD) (kernel.org)
2026-03-23 20:36 ` Lizhi Hou
2026-03-24 21:38 ` Claude Code Review Bot [this message]
2026-03-24 21:38 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260323173719.2311474-1-lizhi.hou@amd.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox