From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/vblank: Extract get_vblank_counter_and_timestamp()
Date: Wed, 25 Mar 2026 07:15:59 +1000 [thread overview]
Message-ID: <review-overall-20260323213645.10965-1-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20260323213645.10965-1-ville.syrjala@linux.intel.com>
Overall Series Review
Subject: drm/vblank: Extract get_vblank_counter_and_timestamp()
Author: Ville Syrjala <ville.syrjala@linux.intel.com>
Patches: 2
Reviewed: 2026-03-25T07:15:59.433526
---
This is a single-patch cleanup that extracts a repeated "read vblank counter and timestamp in a retry loop" pattern from three call sites in `drm_vblank.c` into a new helper function `get_vblank_counter_and_timestamp()`. The refactoring is straightforward, correct, and reduces code duplication. There is one minor semantic difference worth noting but it is harmless.
**Verdict: Looks good.** Clean, simple refactoring.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-24 21:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 21:36 [PATCH] drm/vblank: Extract get_vblank_counter_and_timestamp() Ville Syrjala
2026-03-24 6:28 ` Kandpal, Suraj
2026-03-24 21:15 ` Claude Code Review Bot [this message]
2026-03-24 21:15 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260323213645.10965-1-ville.syrjala@linux.intel.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox