Claude review: drm/bridge: protect encoder bridge chain with a mutex

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: drm/bridge: protect encoder bridge chain with a mutex
Author: Luca Ceresoli <luca.ceresoli@bootlin.com>
Patches: 8
Reviewed: 2026-03-25T06:59:29.998864

---

This is a well-structured v5 series that adds mutex protection to the DRM encoder bridge chain, preparing for hot-pluggable bridge support. The approach is sound: a per-encoder mutex serializes bridge chain modifications (attach/detach) against iterations over the chain. The series is incremental and logical, building from mutex introduction through progressive coverage of all iteration sites.

The ABBA deadlock avoidance in patch 2 (using `list_cut_before` to a temporary list) is clever and correct. The scoped for_each macros in patch 4 are well-designed, using `__free()` cleanup attributes to ensure the mutex is always released even on early return/break.

One concern worth noting: patches 6 and 7 hold the mutex while calling bridge driver callbacks (`atomic_disable`, `atomic_enable`, `pre_enable`, `post_disable`, etc.). If any bridge driver callback were to attempt a bridge attach/detach on the same encoder, this would deadlock. This seems unlikely in practice, but should be documented or at least noted.

Overall: the series looks correct and ready to merge. Minor issues noted below.

---
Generated by Claude Code Patch Reviewer