public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/atomic: protect bridge private_obj during bridge removal
Date: Wed, 25 Mar 2026 06:50:56 +1000	[thread overview]
Message-ID: <review-overall-20260324-drm-bridge-atomic-vs-remove-private_obj-v3-0-64deefe84044@bootlin.com> (raw)
In-Reply-To: <20260324-drm-bridge-atomic-vs-remove-private_obj-v3-0-64deefe84044@bootlin.com>

Overall Series Review

Subject: drm/atomic: protect bridge private_obj during bridge removal
Author: Luca Ceresoli <luca.ceresoli@bootlin.com>
Patches: 2
Reviewed: 2026-03-25T06:50:56.340536

---

This is a single-patch series addressing a real race condition in DRM bridge hot-unplug. The problem is well-understood and clearly documented in the commit message: when a bridge's `private_obj` is being finalized via `drm_bridge_detach()` concurrently with code that holds modeset locks (e.g., `drm_mode_obj_get_properties_ioctl()` using `DRM_MODESET_LOCK_ALL_BEGIN/END`), the `drm_modeset_lock_fini()` call hits a `WARN_ON` because the lock is still on the acquire context's locked list.

The fix is minimal and correct: wrap the `list_del(&obj->head)` in `drm_atomic_private_obj_fini()` with `DRM_MODESET_LOCK_ALL_BEGIN/END`. This serializes the list removal against concurrent lock acquisition, ensuring the private object is either fully locked by the concurrent user (who will finish and release before fini proceeds) or removed from the list before the concurrent user iterates it.

The series is well-motivated as part of ongoing DRM bridge hotplug work, and the roadmap in the cover letter is appreciated.

---
Generated by Claude Code Patch Reviewer

      parent reply	other threads:[~2026-03-24 20:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-24 13:07 [PATCH v3] drm/atomic: protect bridge private_obj during bridge removal Luca Ceresoli
2026-03-24 13:07 ` [PATCH v3] drm/atomic: drm_atomic_private_obj_fini: protect private_obj removal from list Luca Ceresoli
2026-03-24 20:50 ` Claude review: drm/atomic: protect bridge private_obj during bridge removal Claude Code Review Bot
2026-03-24 20:50 ` Claude Code Review Bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-20260324-drm-bridge-atomic-vs-remove-private_obj-v3-0-64deefe84044@bootlin.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox