From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/msm/hdmi & phy: use generic PHY framework
Date: Wed, 25 Mar 2026 07:14:41 +1000 [thread overview]
Message-ID: <review-overall-20260324-fd-hdmi-phy-v7-0-b41dde8d83b8@oss.qualcomm.com> (raw)
In-Reply-To: <20260324-fd-hdmi-phy-v7-0-b41dde8d83b8@oss.qualcomm.com>
Overall Series Review
Subject: drm/msm/hdmi & phy: use generic PHY framework
Author: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Patches: 5
Reviewed: 2026-03-25T07:14:41.691732
---
This v7 series moves the MSM HDMI PHY drivers from `drivers/gpu/drm/msm/` into the generic PHY framework under `drivers/phy/qualcomm/`. The architectural direction is sound — it allows code sharing with other QMP/UniPHY drivers and follows the kernel's PHY subsystem conventions. The series is well-structured: Patch 1 does the bulk move, Patches 2-3 extract shared UniPHY PLL register defines, and Patch 4 adds MSM8974 PLL support.
However, there are two bugs that need fixing before merge, and several minor issues worth addressing.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-24 21:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 22:56 [PATCH v7 0/4] drm/msm/hdmi & phy: use generic PHY framework Dmitry Baryshkov
2026-03-23 22:56 ` [PATCH v7 1/4] drm/msm/hdmi: switch to generic PHY subsystem Dmitry Baryshkov
2026-03-24 21:14 ` Claude review: " Claude Code Review Bot
2026-03-23 22:56 ` [PATCH v7 2/4] phy: qcom: apq8064-sata: extract UNI PLL register defines Dmitry Baryshkov
2026-03-24 21:14 ` Claude review: " Claude Code Review Bot
2026-03-23 22:56 ` [PATCH v7 3/4] phy: qcom-uniphy: add more registers from display PHYs Dmitry Baryshkov
2026-03-24 21:14 ` Claude review: " Claude Code Review Bot
2026-03-23 22:56 ` [PATCH v7 4/4] phy: qualcomm: add MSM8974 HDMI PHY support Dmitry Baryshkov
2026-03-24 21:14 ` Claude review: " Claude Code Review Bot
2026-03-24 21:14 ` Claude Code Review Bot [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-03-19 3:48 [PATCH v6 0/4] drm/msm/hdmi & phy: use generic PHY framework Dmitry Baryshkov
2026-03-21 18:56 ` Claude review: " Claude Code Review Bot
2026-03-14 5:06 [PATCH v5 0/4] " Dmitry Baryshkov
2026-03-16 2:07 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260324-fd-hdmi-phy-v7-0-b41dde8d83b8@oss.qualcomm.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox