From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm/hdmi & phy: use generic PHY framework Date: Wed, 25 Mar 2026 07:14:41 +1000 Message-ID: In-Reply-To: <20260324-fd-hdmi-phy-v7-0-b41dde8d83b8@oss.qualcomm.com> References: <20260324-fd-hdmi-phy-v7-0-b41dde8d83b8@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/msm/hdmi & phy: use generic PHY framework Author: Dmitry Baryshkov Patches: 5 Reviewed: 2026-03-25T07:14:41.691732 --- This v7 series moves the MSM HDMI PHY drivers from `drivers/gpu/drm/msm/` i= nto the generic PHY framework under `drivers/phy/qualcomm/`. The architectu= ral direction is sound =E2=80=94 it allows code sharing with other QMP/UniP= HY drivers and follows the kernel's PHY subsystem conventions. The series i= s well-structured: Patch 1 does the bulk move, Patches 2-3 extract shared U= niPHY PLL register defines, and Patch 4 adds MSM8974 PLL support. However, there are two bugs that need fixing before merge, and several mino= r issues worth addressing. --- Generated by Claude Code Patch Reviewer