From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: misc: fastrpc: keep copied arguments inside the invoke buffer
Date: Wed, 25 Mar 2026 07:05:25 +1000 [thread overview]
Message-ID: <review-overall-20260324014459.93364-1-pengpeng@iscas.ac.cn> (raw)
In-Reply-To: <20260324014459.93364-1-pengpeng@iscas.ac.cn>
Overall Series Review
Subject: misc: fastrpc: keep copied arguments inside the invoke buffer
Author: Pengpeng Hou <pengpeng@iscas.ac.cn>
Patches: 2
Reviewed: 2026-03-25T07:05:25.189660
---
This is a single-patch series adding bounds validation to `fastrpc_get_args()` in the Qualcomm FastRPC driver. The patch addresses a real issue: the overlap-derived destination pointer (`args - ctx->olaps[oix].offset`) is used for `copy_from_user()` without checking that it remains within the allocated invoke buffer. Since `olaps` values are derived from user-controlled argument pointers/lengths (via `fastrpc_get_buff_overlaps()`), a malicious user could potentially write outside the buffer.
The fix is reasonable and the approach is sound, but there are a couple of issues worth noting.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-24 21:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-24 1:44 [PATCH] misc: fastrpc: keep copied arguments inside the invoke buffer Pengpeng Hou
2026-03-24 9:41 ` Konrad Dybcio
2026-03-24 21:05 ` Claude Code Review Bot [this message]
2026-03-24 21:05 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260324014459.93364-1-pengpeng@iscas.ac.cn \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox