From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm: verisilicon: add hardware cursor support Date: Wed, 25 Mar 2026 07:03:50 +1000 Message-ID: In-Reply-To: <20260324060222.2029061-1-zhengxingda@iscas.ac.cn> References: <20260324060222.2029061-1-zhengxingda@iscas.ac.cn> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm: verisilicon: add hardware cursor support Author: Icenowy Zheng Patches: 3 Reviewed: 2026-03-25T07:03:50.855249 --- This is a clean, well-structured 2-patch series adding hardware cursor plan= e support to the Verisilicon DRM driver. The approach =E2=80=94 adding HWDB= metadata first, then implementing the cursor plane =E2=80=94 is logical. T= he code is reasonably well written and follows existing driver conventions.= There are several issues to address, mostly around missing `FIELD_PREP` us= age for register field values and a missing `mode_config.cursor_width/heigh= t` setup. --- Generated by Claude Code Patch Reviewer