From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/amdkfd: stop speculation on the kfd_ioctl path
Date: Wed, 25 Mar 2026 06:37:21 +1000 [thread overview]
Message-ID: <review-overall-2026032408-divided-racing-fe78@gregkh> (raw)
In-Reply-To: <2026032408-divided-racing-fe78@gregkh>
Overall Series Review
Subject: drm/amdkfd: stop speculation on the kfd_ioctl path
Author: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Patches: 1
Reviewed: 2026-03-25T06:37:21.620119
---
This is a single-patch series from Greg Kroah-Hartman adding a Spectre v1 mitigation to the KFD ioctl dispatch path. The intent is correct — `nr` is derived from user-controlled `cmd` via `_IOC_NR()`, and is used to index into the `amdkfd_ioctls[]` function pointer table. This is a classic Spectre v1 gadget. The fix uses `array_index_nospec()` to clamp the index under speculation.
The patch is **correct and appropriate**, though the placement of the barrier could be slightly improved. Overall this is a reasonable hardening patch suitable for stable backport.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-03-24 20:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-24 16:39 [PATCH] drm/amdkfd: stop speculation on the kfd_ioctl path Greg Kroah-Hartman
2026-03-24 20:37 ` Claude review: " Claude Code Review Bot
2026-03-24 20:37 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-2026032408-divided-racing-fe78@gregkh \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox