From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/amdkfd: stop speculation on the kfd_ioctl path Date: Wed, 25 Mar 2026 06:37:21 +1000 Message-ID: In-Reply-To: <2026032408-divided-racing-fe78@gregkh> References: <2026032408-divided-racing-fe78@gregkh> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/amdkfd: stop speculation on the kfd_ioctl path Author: Greg Kroah-Hartman Patches: 1 Reviewed: 2026-03-25T06:37:21.620119 --- This is a single-patch series from Greg Kroah-Hartman adding a Spectre v1 m= itigation to the KFD ioctl dispatch path. The intent is correct =E2=80=94 `= nr` is derived from user-controlled `cmd` via `_IOC_NR()`, and is used to i= ndex into the `amdkfd_ioctls[]` function pointer table. This is a classic S= pectre v1 gadget. The fix uses `array_index_nospec()` to clamp the index un= der speculation. The patch is **correct and appropriate**, though the placement of the barri= er could be slightly improved. Overall this is a reasonable hardening patch= suitable for stable backport. --- Generated by Claude Code Patch Reviewer