From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/syncobj: Fix xa_alloc allocation flags
Date: Wed, 25 Mar 2026 06:54:12 +1000 [thread overview]
Message-ID: <review-overall-20260324111019.22467-1-tvrtko.ursulin@igalia.com> (raw)
In-Reply-To: <20260324111019.22467-1-tvrtko.ursulin@igalia.com>
Overall Series Review
Subject: drm/syncobj: Fix xa_alloc allocation flags
Author: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
Patches: 3
Reviewed: 2026-03-25T06:54:12.925532
---
This is a single-patch fix for an incorrect GFP allocation flag in `drm_syncobj.c`. The analysis is correct and the fix is straightforward. When the IDR-to-xarray conversion was done (commit `fec2c3c01f1c`), the old pattern was `idr_preload(GFP_KERNEL)` followed by `idr_alloc(..., GFP_NOWAIT)`. The preload did the actual memory allocation with `GFP_KERNEL` (which can sleep), while the `idr_alloc` just used a pre-allocated node. When converting to `xa_alloc`, the `idr_preload` was correctly removed, but the `GFP_NOWAIT` was incorrectly preserved — `xa_alloc` does its own allocation inline, so it needs `GFP_KERNEL` to be able to sleep and retry allocations.
The fix looks correct and complete.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-24 20:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-24 11:10 [PATCH] drm/syncobj: Fix xa_alloc allocation flags Tvrtko Ursulin
2026-03-24 11:12 ` Thomas Hellström
2026-03-24 11:27 ` Girotra, Himanshu
2026-03-24 20:54 ` Claude Code Review Bot [this message]
2026-03-24 20:54 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260324111019.22467-1-tvrtko.ursulin@igalia.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox