From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/syncobj: Fix xa_alloc allocation flags Date: Wed, 25 Mar 2026 06:54:12 +1000 Message-ID: In-Reply-To: <20260324111019.22467-1-tvrtko.ursulin@igalia.com> References: <20260324111019.22467-1-tvrtko.ursulin@igalia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/syncobj: Fix xa_alloc allocation flags Author: Tvrtko Ursulin Patches: 3 Reviewed: 2026-03-25T06:54:12.925532 --- This is a single-patch fix for an incorrect GFP allocation flag in `drm_syn= cobj.c`. The analysis is correct and the fix is straightforward. When the I= DR-to-xarray conversion was done (commit `fec2c3c01f1c`), the old pattern w= as `idr_preload(GFP_KERNEL)` followed by `idr_alloc(..., GFP_NOWAIT)`. The = preload did the actual memory allocation with `GFP_KERNEL` (which can sleep= ), while the `idr_alloc` just used a pre-allocated node. When converting to= `xa_alloc`, the `idr_preload` was correctly removed, but the `GFP_NOWAIT` = was incorrectly preserved =E2=80=94 `xa_alloc` does its own allocation inli= ne, so it needs `GFP_KERNEL` to be able to sleep and retry allocations. The fix looks correct and complete. --- Generated by Claude Code Patch Reviewer