From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/xe/xe_vm: Implement xe_vm_get_property_ioctl Date: Wed, 25 Mar 2026 06:46:43 +1000 Message-ID: In-Reply-To: <20260324152935.72444-6-jonathan.cavitt@intel.com> References: <20260324152935.72444-6-jonathan.cavitt@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/xe/xe_vm: Implement xe_vm_get_property_ioctl Author: Jonathan Cavitt Patches: 5 Reviewed: 2026-03-25T06:46:43.451179 --- This v39 series adds a new `DRM_IOCTL_XE_VM_GET_PROPERTY` ioctl to allow us= erspace to query up to 50 failed page faults per VM. The series is well-str= uctured across 4 patches: a preparatory bug fix, uAPI definitions, internal= fault storage, and the ioctl implementation. After 39 revisions, the code = is generally clean, but there are several issues worth flagging =E2=80=94 m= ost notably missing validation of the `pad` field in the ioctl, comma-inste= ad-of-semicolon bugs, a TOCTOU race in the size check, and the `copy_to_use= r` copying more data than was actually populated. --- Generated by Claude Code Patch Reviewer