From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: accel/amdxdna: Add per-process BO memory usage query support
Date: Wed, 25 Mar 2026 06:39:41 +1000 [thread overview]
Message-ID: <review-overall-20260324163159.2425461-1-lizhi.hou@amd.com> (raw)
In-Reply-To: <20260324163159.2425461-1-lizhi.hou@amd.com>
Overall Series Review
Subject: accel/amdxdna: Add per-process BO memory usage query support
Author: Lizhi Hou <lizhi.hou@amd.com>
Patches: 2
Reviewed: 2026-03-25T06:39:41.810597
---
This is a single patch adding per-process BO memory usage query support to the amdxdna accelerator driver. The feature introduces a new `DRM_AMDXDNA_BO_USAGE` query type through the existing `GET_ARRAY` UAPI, tracks BO memory usage per-client via counters maintained in GEM open/close and heap alloc/free paths, and exposes the data to userspace.
The approach is reasonable overall, but there are several issues with the UAPI design, locking, and reference counting that need attention. The patch was also clearly developed against an older base — the current drm-next tree already has `ref` and `close` callbacks in the gem layer, so the patch renames `ref` to `open_ref` and introduces a `close` that already exists.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-24 20:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-24 16:31 [PATCH V1] accel/amdxdna: Add per-process BO memory usage query support Lizhi Hou
2026-03-24 17:01 ` Mario Limonciello
2026-03-24 20:39 ` Claude Code Review Bot [this message]
2026-03-24 20:39 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260324163159.2425461-1-lizhi.hou@amd.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox