From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: accel/amdxdna: Add per-process BO memory usage query support Date: Wed, 25 Mar 2026 06:39:41 +1000 Message-ID: In-Reply-To: <20260324163159.2425461-1-lizhi.hou@amd.com> References: <20260324163159.2425461-1-lizhi.hou@amd.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: accel/amdxdna: Add per-process BO memory usage query support Author: Lizhi Hou Patches: 2 Reviewed: 2026-03-25T06:39:41.810597 --- This is a single patch adding per-process BO memory usage query support to = the amdxdna accelerator driver. The feature introduces a new `DRM_AMDXDNA_B= O_USAGE` query type through the existing `GET_ARRAY` UAPI, tracks BO memory= usage per-client via counters maintained in GEM open/close and heap alloc/= free paths, and exposes the data to userspace. The approach is reasonable overall, but there are several issues with the U= API design, locking, and reference counting that need attention. The patch = was also clearly developed against an older base =E2=80=94 the current drm-= next tree already has `ref` and `close` callbacks in the gem layer, so the = patch renames `ref` to `open_ref` and introduces a `close` that already exi= sts. --- Generated by Claude Code Patch Reviewer