From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/amdgpu: fix sleeping allocation under spinlock in PASID IDR Date: Tue, 31 Mar 2026 17:50:57 +1000 Message-ID: In-Reply-To: <20260328213900.19255-1-mikhail.v.gavrilov@gmail.com> References: <20260328213900.19255-1-mikhail.v.gavrilov@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/amdgpu: fix sleeping allocation under spinlock in PASID IDR Author: Mikhail Gavrilov Patches: 2 Reviewed: 2026-03-31T17:50:57.526600 --- This is a single-patch fix for a real bug: `GFP_KERNEL` allocation inside a= spinlock critical section, which can sleep and trigger a BUG with lockdep = or `CONFIG_PREEMPT`. The fix uses the standard `idr_preload()` / `GFP_NOWAI= T` pattern, which is the well-established kernel idiom for exactly this sit= uation. The commit message is excellent =E2=80=94 it clearly explains the b= ug, includes a lockdep splat, explains why a mutex isn't viable (IRQ contex= t in `amdgpu_pasid_free_cb`), and documents the chosen solution. **Verdict: This patch looks correct and ready to merge.** --- Generated by Claude Code Patch Reviewer