From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dt-bindings: display: bridge: ldb: Require reg property only for i.MX6SX/8MP LDBs Date: Tue, 31 Mar 2026 17:49:51 +1000 Message-ID: In-Reply-To: <20260329-fsl_ldb_schema_fix-v1-1-351372754bc0@nxp.com> References: <20260329-fsl_ldb_schema_fix-v1-1-351372754bc0@nxp.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: dt-bindings: display: bridge: ldb: Require reg property only for i.MX6SX/8MP LDBs Author: Liu Ying Patches: 8 Reviewed: 2026-03-31T17:49:51.247576 --- This is a single-patch fix to the `fsl,ldb.yaml` dt-bindings schema. The problem is real: the i.MX93 LDB is a child of a syscon (Media blk-ctrl) that doesn't allow `reg` properties in its children, but the schema currently requires `reg` globally for all LDB variants. The fix correctly makes `reg` (and `reg-names`) conditional on the specific compatible strings that need them. The patch is logically sound and the approach of using per-compatible `if/then` blocks is the standard dt-bindings pattern for this kind of differentiation. **No significant issues found.** --- Generated by Claude Code Patch Reviewer