From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/atomic: fix vblank event leak in complete_signaling() Date: Tue, 31 Mar 2026 17:48:23 +1000 Message-ID: In-Reply-To: <20260329073423.8390-1-abhishek_sts8@yahoo.com> References: <20260329073423.8390-1-abhishek_sts8@yahoo.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/atomic: fix vblank event leak in complete_signaling() Author: Abhishek Kumar Patches: 1 Reviewed: 2026-03-31T17:48:23.896386 --- This is a single-patch fix for a real memory leak reported by syzbot. The analysis is correct: there is a window in `prepare_signaling()` where an event is allocated and assigned to `crtc_state->event`, but an error occurs before either `file_priv` or `fence` is set on it. The existing cleanup in `complete_signaling()` misses this case. The fix is reasonable and targeted. **Verdict: The fix addresses a real bug, but the approach has a fragility concern worth discussing.** --- Generated by Claude Code Patch Reviewer