From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dma/contiguous: Fix broken build Date: Tue, 31 Mar 2026 17:29:36 +1000 Message-ID: In-Reply-To: <20260330-dma-build-fix-v1-1-748b64f0d8af@kernel.org> References: <20260330-dma-build-fix-v1-1-748b64f0d8af@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: dma/contiguous: Fix broken build Author: Maxime Ripard Patches: 5 Reviewed: 2026-03-31T17:29:36.009744 --- This is a single-patch build fix for a regression introduced by commit `3a236f6a5cf2` ("dma: contiguous: Turn heap registration logic around"). That commit changed the CMA heap registration model so the CMA heap driver discovers CMA areas itself (via `dev_get_cma_area()` in `add_cma_heaps()`), but left behind one stale call to the now-removed `dma_heap_cma_register_heap()` in `dma_contiguous_reserve()`, breaking the build. The fix is clean and correct: it removes the dead call, deletes the now-empty header, and removes all includes of that header. The only two files that included the header (`cma_heap.c` and `contiguous.c`) are both addressed. **Verdict: Looks good.** One minor nit on the commit message wording below. --- Generated by Claude Code Patch Reviewer