From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dma/contiguous: Fix broken build Date: Tue, 31 Mar 2026 17:07:44 +1000 Message-ID: In-Reply-To: <20260330-dma-build-fix-v2-1-26d844575815@kernel.org> References: <20260330-dma-build-fix-v2-1-26d844575815@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: dma/contiguous: Fix broken build Author: Maxime Ripard Patches: 2 Reviewed: 2026-03-31T17:07:44.040479 --- This is a single-patch build fix from Maxime Ripard addressing a broken build caused by commit 3a236f6a5cf2 ("dma: contiguous: Turn heap registration logic around") which removed the definition of `dma_heap_cma_register_heap()` but left behind a call site in `dma_contiguous_reserve()`. The fix is logically sound: it replaces the dangling call with `rmem_cma_insert_area()` (introduced by the same broken commit), removes the now-empty header `linux/dma-buf/heaps/cma.h`, and cleans up all includes of it. The approach of queueing the CMA area via `rmem_cma_insert_area()` instead of directly registering the heap aligns with the new registration architecture that 3a236f6a5cf2 intended. There are a couple of minor observations but nothing blocking. --- Generated by Claude Code Patch Reviewer