From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/mxsfb/lcdif: use DRM_BRIDGE_ATTACH_NO_CONNECTOR and the bridge-connector Date: Tue, 31 Mar 2026 16:54:42 +1000 Message-ID: In-Reply-To: <20260330-drm-lcdif-dbanc-v2-0-c7f2af536a24@bootlin.com> References: <20260330-drm-lcdif-dbanc-v2-0-c7f2af536a24@bootlin.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/mxsfb/lcdif: use DRM_BRIDGE_ATTACH_NO_CONNECTOR and the bridge-connector Author: Luca Ceresoli Patches: 11 Reviewed: 2026-03-31T16:54:42.874753 --- This is a well-structured 10-patch series that modernizes the i.MX8MP LCDIF driver to use `DRM_BRIDGE_ATTACH_NO_CONNECTOR` with the `drm_bridge_connector` framework, which is the current DRM best practice. The series is logically ordered: patches 1-4 are clean preparatory cleanups to lcdif_drv.c, patches 5-6 improve dw-hdmi documentation and validation, patch 7 resolves a devlink/probe-ordering problem, patch 8 provides DT backward compatibility via an overlay, patch 9 enables the new mode in imx8mp-hdmi-tx, and patch 10 makes the final LCDIF conversion. The approach is sound and the backward-compatibility strategy using DT overlays (following the tilcdc precedent) is reasonable. The series deserves broad hardware testing given the regression potential on i.MX8MP HDMI boards. A few issues noted below, mostly minor, with one moderate concern in patch 7 and one dead-variable issue in patch 8. --- Generated by Claude Code Patch Reviewer