From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm: default separate_gpu_kms to auto selection Date: Tue, 31 Mar 2026 17:21:55 +1000 Message-ID: In-Reply-To: <20260330-separate_gpu_kms-v3-1-a3e54b9c9417@oss.qualcomm.com> References: <20260330-separate_gpu_kms-v3-1-a3e54b9c9417@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/msm: default separate_gpu_kms to auto selection Author: Mahadevan P Patches: 1 Reviewed: 2026-03-31T17:21:55.073456 --- This is a single patch (v3) that changes the `separate_gpu_kms` module parameter from a boolean to a tristate (`-1`/`0`/`1`), adding an auto-detection mode that counts GPUs and display subsystems to decide whether to bind them together or expose them as separate DRM devices. The motivation is clear: platforms like SA8775P with multiple display subsystems need them to probe independently. The design is reasonable and the auto-detection logic is sound. However, there is a **device node reference leak** that must be fixed before this can be merged, and a few minor points worth addressing. --- Generated by Claude Code Patch Reviewer