From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Fix Adaptive Sync SDP for PR with Link ON + Auxless ALPM Date: Tue, 31 Mar 2026 17:39:44 +1000 Message-ID: In-Reply-To: <20260330040656.4116502-1-ankit.k.nautiyal@intel.com> References: <20260330040656.4116502-1-ankit.k.nautiyal@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: Fix Adaptive Sync SDP for PR with Link ON + Auxless ALPM Author: Ankit Nautiyal Patches: 33 Reviewed: 2026-03-31T17:39:44.871086 --- This 19-patch series adds Adaptive Sync SDP support for Panel Replay with L= ink ON and Auxless ALPM (Link-Off) configurations, building on existing AS = SDP infrastructure. The series is well-structured: patches 1-5 are cleanup/= fixes to existing code, patches 6-11 add guardrails and correctness improve= ments, patches 12-13 add infrastructure, and patches 14-19 implement the ne= w functionality. The series has good review coverage from Ville Syrj=C3=A4l=C3=A4 on many pa= tches. The overall architecture of splitting AS SDP computation into early = (enable flag for guardband) and late (actual fields) phases is sound. **Key concerns:** 1. **Bug in patch 12**: `drm_dp_dpcd_read_byte()` returns 0 on success, not= 1. The series checks `=3D=3D 1`, which will always fail. 2. **Patch 7 changes `assume_all_enabled` semantics** without updating all = callers =E2=80=94 this could cause regressions in guardband calculations. 3. **Patch 15 extends the burst write to 3 bytes** but assumes PANEL_REPLAY= _CONFIG3 is at offset 0x1b2 (contiguous with CONFIG/CONFIG2) =E2=80=94 this= should be verified against the spec, as PANEL_REPLAY_CONFIG3 was defined a= t 0x11a in patch 4. --- --- Generated by Claude Code Patch Reviewer