From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: accel/ivpu: Add support for limiting NPU frequency
Date: Tue, 31 Mar 2026 17:27:17 +1000 [thread overview]
Message-ID: <review-overall-20260330083815.1806045-1-andrzej.kacprowski@linux.intel.com> (raw)
In-Reply-To: <20260330083815.1806045-1-andrzej.kacprowski@linux.intel.com>
Overall Series Review
Subject: accel/ivpu: Add support for limiting NPU frequency
Author: Andrzej Kacprowski <andrzej.kacprowski@linux.intel.com>
Patches: 2
Reviewed: 2026-03-31T17:27:17.638106
---
This is a single patch adding sysfs-based NPU frequency limiting to the Intel IVPU (NPU) accelerator driver. The feature is well-structured overall: it adds a `freq/` sysfs subdirectory with hardware info and configurable min/max frequency attributes, communicates changes to firmware via a new JSM message, and maintains backward compatibility with existing sysfs attributes.
However, there are several bugs and issues that need to be addressed before merging.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-31 7:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-30 8:38 [PATCH] accel/ivpu: Add support for limiting NPU frequency Andrzej Kacprowski
2026-03-31 6:12 ` Jeff Hugo
2026-03-31 7:27 ` Claude review: " Claude Code Review Bot
2026-03-31 7:27 ` Claude Code Review Bot [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-04-08 13:08 [PATCH v2] " Andrzej Kacprowski
2026-04-12 2:24 ` Claude review: " Claude Code Review Bot
2026-04-12 2:24 ` Claude Code Review Bot
2026-04-08 15:01 [PATCH v3] " Andrzej Kacprowski
2026-04-12 2:19 ` Claude review: " Claude Code Review Bot
2026-04-12 2:19 ` Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260330083815.1806045-1-andrzej.kacprowski@linux.intel.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox