From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/panthor: Add a GEM shrinker Date: Tue, 31 Mar 2026 17:24:45 +1000 Message-ID: In-Reply-To: <20260330094848.2169422-1-boris.brezillon@collabora.com> References: <20260330094848.2169422-1-boris.brezillon@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/panthor: Add a GEM shrinker Author: Boris Brezillon Patches: 11 Reviewed: 2026-03-31T17:24:45.257645 --- This is a well-structured 9-patch series adding GEM shrinker support to the panthor GPU driver. The series is at v6 and has already collected Reviewed-by from both Steven Price and Liviu Dudau on all patches. The approach is sound: first fork away from `drm_gem_shmem_object` to gain control over page lifetimes (patch 5), add lazy page allocation on mmap (patch 6), prepare the infrastructure (patches 7-8), then implement the shrinker itself (patch 9). The preparatory patches (1-4) are clean and low-risk. The locking strategy (trylock everywhere in the reclaim path) is pragmatic given the lock ordering constraints. The tiered LRU approach (unused -> mmapped -> single-VM GPU mapped -> multi-VM GPU mapped) is reasonable. The series has clearly benefited from multiple review rounds and addresses prior concerns well. A few items are worth attention, mostly in the large patch 9. --- Generated by Claude Code Patch Reviewer