From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dma-fence: Move signalling tracepoint to before ops detach Date: Tue, 31 Mar 2026 17:14:43 +1000 Message-ID: In-Reply-To: <20260330133623.17704-1-tvrtko.ursulin@igalia.com> References: <20260330133623.17704-1-tvrtko.ursulin@igalia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: dma-fence: Move signalling tracepoint to before ops detach Author: Tvrtko Ursulin Patches: 2 Reviewed: 2026-03-31T17:14:43.479696 --- This is a single-patch bugfix for a NULL pointer dereference introduced by commit 541c8f2468b9 ("dma-buf: detach fence ops on signal v3"). The fix is correct, straightforward, and clearly necessary. The tracepoint class at line 24 of `dma_fence.h` accesses `fence->ops->get_driver_name(fence)` and `fence->ops->get_timeline_name(fence)`, which will crash if `fence->ops` has been set to NULL by the ops detach logic added in the Fixes commit. The patch is **good to merge** as-is. --- Generated by Claude Code Patch Reviewer