From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/amdgpu: replace PASID IDR with XArray Date: Tue, 31 Mar 2026 17:08:59 +1000 Message-ID: In-Reply-To: <20260330145049.21936-1-mikhail.v.gavrilov@gmail.com> References: <20260330145049.21936-1-mikhail.v.gavrilov@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/amdgpu: replace PASID IDR with XArray Author: Mikhail Gavrilov Patches: 3 Reviewed: 2026-03-31T17:08:59.509731 --- This is a single well-motivated bugfix patch (v4) that replaces the IDR + s= pinlock PASID allocator with XArray to fix two real locking bugs introduced= by commit 8f1de51f49be: 1. `GFP_KERNEL` allocation under `spin_lock()` (can sleep) 2. Plain `spin_lock()` used in process context while `amdgpu_pasid_free()` = can be called from hardirq context (deadlock) The XArray conversion is the right approach =E2=80=94 `xa_alloc_cyclic()` h= andles internal locking with proper IRQ safety, and `xa_erase()` is inheren= tly IRQ-safe. The patch is clean, well-explained, and has gone through good= iteration (v1=E2=86=92v4) with reviewer feedback from Lijo Lazar. **Verdict: This patch looks correct and ready for merge.** One minor nit be= low. --- Generated by Claude Code Patch Reviewer