From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: gpu: nova-core: bitfield: fix broken Default implementation Date: Wed, 01 Apr 2026 07:59:01 +1000 Message-ID: In-Reply-To: <20260331-fix-bitfield-v1-1-ebe1a72b4fae@nvidia.com> References: <20260331-fix-bitfield-v1-1-ebe1a72b4fae@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: gpu: nova-core: bitfield: fix broken Default implementation Author: Eliot Courtney Patches: 5 Reviewed: 2026-04-01T07:59:01.227236 --- This is a single-patch bugfix for a real bug in the `bitfield!` macro's `Default` implementation in the nova-core driver. The bug is clear: the `set_*` methods use a builder pattern (taking `self` by value and returning `Self`), but the `Default` implementation discards the return values, so field defaults are never actually applied. The fix is correct and minimal, and the added kunit test properly validates the fix. **Recommended for merging.** --- Generated by Claude Code Patch Reviewer