From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/panel: simple: add Waveshare LCD panels Date: Wed, 01 Apr 2026 07:39:19 +1000 Message-ID: In-Reply-To: <20260331-ws-lcd-v2-0-a1add63b6eb6@oss.qualcomm.com> References: <20260331-ws-lcd-v2-0-a1add63b6eb6@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/panel: simple: add Waveshare LCD panels Author: Dmitry Baryshkov Patches: 5 Reviewed: 2026-04-01T07:39:19.359525 --- This is a well-structured, straightforward series by Dmitry Baryshkov adding support for additional Waveshare DSI LCD panel kits. The series is logically organized: bindings first (patches 1 and 3), then driver support (patches 2 and 4). The technical approach is sound -- reusing the existing waveshare-dsi bridge driver with a new compatible for LVDS variants, and adding panel timing definitions in panel-simple.c. The series has one notable issue: **missing trailing commas** in the OF match table entries in patch 4. There is also a forward declaration of `waveshare_80_lcd_c_mode` that, while functional, could be avoided by reordering the definitions. Overall this looks ready with minor style fixes. --- --- Generated by Claude Code Patch Reviewer