From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm: verisilicon: convert drm_format to vs_format in atomic_check Date: Tue, 31 Mar 2026 16:44:29 +1000 Message-ID: In-Reply-To: <20260331060126.1291966-1-zhengxingda@iscas.ac.cn> References: <20260331060126.1291966-1-zhengxingda@iscas.ac.cn> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm: verisilicon: convert drm_format to vs_format in atomic_check Author: Icenowy Zheng Patches: 6 Reviewed: 2026-03-31T16:44:29.302372 --- This is a well-structured 4-patch series that moves the `drm_format` to `vs= _format` conversion from `atomic_update` (which cannot fail) to `atomic_che= ck` (which can properly return errors). The series is on v4 and already has= Reviewed-by tags from Thomas Zimmermann on all patches. The approach is co= rrect and follows standard DRM patterns. The patches are logically ordered = and each patch is self-contained. One minor issue: in patch 3, passing `NULL` for `crtc_state` to `drm_atomic= _helper_check_plane_state()` will trigger a `WARN_ON` inside that helper (l= ine 907: `WARN_ON(plane_state->crtc && plane_state->crtc !=3D crtc_state->c= rtc)`). However, since `crtc` is also NULL in that case, the dereference of= `crtc_state->crtc` is guarded by the short-circuit evaluation of `plane_st= ate->crtc` being NULL. And line 918 has `WARN_ON(!plane_state->crtc)` which= fires but harmlessly returns `visible =3D false`. This is a known/accepted= pattern =E2=80=94 the helper itself handles the NULL crtc case (with a war= ning that `fb` without `crtc` is odd), and the real fix is ensuring `drm_at= omic_helper_check_plane_state()` gets called at all for cleanup purposes. Overall: **Looks good.** Series is ready for merge. --- Generated by Claude Code Patch Reviewer