From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Minor hmm_test fixes and cleanups Date: Tue, 31 Mar 2026 16:41:09 +1000 Message-ID: In-Reply-To: <20260331063445.3551404-1-apopple@nvidia.com> References: <20260331063445.3551404-1-apopple@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: Minor hmm_test fixes and cleanups Author: Alistair Popple Patches: 4 Reviewed: 2026-03-31T16:41:09.620184 --- This is a well-structured 3-patch series fixing real bugs and warnings in the HMM kernel selftests (`lib/test_hmm.c` and `tools/testing/selftests/mm/hmm-tests.c`). The fixes are appropriate and well-motivated: 1. **Patch 1** fixes a use-after-free crash path reported on arm64 by evicting device pages before freeing the dmirror struct on file close. 2. **Patch 2** fixes portability issues on architectures where PMD size != 2MB (e.g., arm64 with 64K base pages), and cleans up a custom helper in favor of existing utilities. 3. **Patch 3** adds a proper `device.release` method to silence a kernel warning on module unload, and fixes a minor error-handling bug. The series is generally **good to merge** with a couple of observations below. --- Generated by Claude Code Patch Reviewer