From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm/dpu: eliza: Use Eliza-specific CWB array Date: Wed, 01 Apr 2026 07:37:06 +1000 Message-ID: In-Reply-To: <20260331161156.211623-2-krzysztof.kozlowski@oss.qualcomm.com> References: <20260331161156.211623-2-krzysztof.kozlowski@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/msm/dpu: eliza: Use Eliza-specific CWB array Author: Krzysztof Kozlowski Patches: 2 Reviewed: 2026-04-01T07:37:06.969698 --- This is a single-patch fix for a copy-paste bug in the Eliza SoC DPU catalo= g definition. The `.cwb` field incorrectly references `sm8650_cwb` while `.= cwb_count` correctly uses `ARRAY_SIZE(eliza_cwb)`. The fix is straightforwa= rd and correct =E2=80=94 use the Eliza-specific CWB array as intended. The patch is low-risk. As the commit message notes, the mismatch likely has= no noticeable functional impact because the arrays are probably the same s= ize and similar in content, but it is clearly wrong and confusing. **One observation worth raising:** The same copy-paste bug pattern (`.cwb = =3D sm8650_cwb` with a local `_cwb` array) appears to exist in other catalo= g files in the tree: `dpu_12_0_sm8750.h`, `dpu_12_2_glymur.h`, and `dpu_13_= 0_kaanapali.h`. The author may want to fix those in follow-up patches (or t= hey may already be fixed in -next). --- Generated by Claude Code Patch Reviewer