From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: accel/amdxdna: Support read-only user-pointer BO mappings
Date: Wed, 01 Apr 2026 07:35:33 +1000 [thread overview]
Message-ID: <review-overall-20260331172635.3275296-1-lizhi.hou@amd.com> (raw)
In-Reply-To: <20260331172635.3275296-1-lizhi.hou@amd.com>
Overall Series Review
Subject: accel/amdxdna: Support read-only user-pointer BO mappings
Author: Lizhi Hou <lizhi.hou@amd.com>
Patches: 2
Reviewed: 2026-04-01T07:35:33.389139
---
This is a single patch (V2) that adds read-only user-pointer BO support to the amdxdna accelerator driver. The motivation is sound: allowing userptr BOs backed by read-only mappings (e.g., read-only mmap'd files) to be pinned and exported without requiring write access, which previously failed unconditionally due to `FOLL_WRITE`.
The approach is reasonable — check VMA permissions, skip `FOLL_WRITE` when all entries are read-only, and export the dmabuf with `O_RDONLY`. However, there are several issues around the VMA checking function, TOCTOU considerations, and missing enforcement on the DMA-BUF side that should be addressed.
---
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-31 21:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-31 17:26 [PATCH V2] accel/amdxdna: Support read-only user-pointer BO mappings Lizhi Hou
2026-03-31 17:52 ` Mario Limonciello
2026-03-31 21:35 ` Claude Code Review Bot [this message]
2026-03-31 21:35 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260331172635.3275296-1-lizhi.hou@amd.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox