From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: gpu: nova-core: require little endian Date: Sun, 12 Apr 2026 14:47:44 +1000 Message-ID: In-Reply-To: <20260406-fix-kconfig-v1-1-8f634499f7f0@nvidia.com> References: <20260406-fix-kconfig-v1-1-8f634499f7f0@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: gpu: nova-core: require little endian Author: Eliot Courtney Patches: 9 Reviewed: 2026-04-12T14:47:44.840568 --- This is a single-patch series adding `depends on !CPU_BIG_ENDIAN` to the no= va-core Kconfig. The change is **correct in intent and low-risk**. The nova= -core driver does assume little-endian byte order in multiple places =E2=80= =94 both via explicit `from_le_bytes()` calls (in `falcon.rs`, `vbios.rs`) = and, more critically, via `FromBytes` / `from_bytes_copy_prefix()` patterns= that reinterpret raw byte slices as structs without any endianness convers= ion (e.g., `PcirStruct`, `BitHeader`, `NpdeStruct`, `PmuLookupTableHeader` = in `vbios.rs`). The GSP firmware command queue code also directly interpret= s byte buffers. The commit message's claim that "RUST transitively depends on !CPU_BIG_ENDI= AN" is practically true today but slightly imprecise =E2=80=94 on arm64, `C= PU_BIG_ENDIAN` depends on `BROKEN`, so it can't actually be selected, but i= t's not a hard Kconfig dependency of `RUST` itself. This makes the patch mo= re of a "belt and suspenders" measure, which is fine =E2=80=94 it makes the= requirement explicit and future-proof in case the arm64 big-endian situati= on ever changes. The patch is simple, correct, and harmless. **Recommend accepting.** --- --- Generated by Claude Code Patch Reviewer