From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/tegra: Enable cmu for Tegra186 and Tegra194 Date: Sun, 12 Apr 2026 14:39:02 +1000 Message-ID: In-Reply-To: <20260406-tegra-drm-cmu-v3-1-dfcb1dda4ad6@gmail.com> References: <20260406-tegra-drm-cmu-v3-1-dfcb1dda4ad6@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/tegra: Enable cmu for Tegra186 and Tegra194 Author: Aaron Kling via B4 Relay Patches: 2 Reviewed: 2026-04-12T14:39:02.640673 --- This is a single-patch series (v3) that enables the Color Management Unit (CMU) on Tegra186/Tegra194 nvdisplay hardware, loading an sRGB LUT to correct dark color output. The motivation is sound -- without CMU, colors are noticeably darker than intended, and the vendor bootloader/downstream driver both enable this. The implementation is straightforward: allocate a DMA-coherent buffer at probe time, populate it with an sRGB correction table, and program the CMU registers during HDMI and DisplayPort enable paths. v3 improvements (dmam_alloc_coherent, removal of improper IOVA null check) are welcome simplifications. **Key issues:** - Missing `Signed-off-by` for the `Co-developed-by` tag (process requirement). - The HDMI and DP paths duplicate the LUT programming sequence -- could be a small helper. - Minor style nits. Overall this looks correct and ready with the tagging fix. --- --- Generated by Claude Code Patch Reviewer