From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/imx/ipuv3: do not adjust hactive for non-8-pixel-aligned modes Date: Sun, 12 Apr 2026 14:28:30 +1000 Message-ID: In-Reply-To: <20260406153654.2094908-1-magnus@alefors.se> References: <20260406153654.2094908-1-magnus@alefors.se> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/imx/ipuv3: do not adjust hactive for non-8-pixel-aligned modes Author: =?UTF-8?q?Magnus=20H=C3=B6rlin?= Patches: 2 Reviewed: 2026-04-12T14:28:30.850076 --- This is a single patch that removes the 8-pixel alignment rounding of `hactive` in the IPUv3 display driver, motivated by fixing visible skewing on displays whose native width is not 8-pixel aligned (e.g. 854x480). The approach is reasonable and the commit message is well-written with clear motivation. The core argument is sound: `ipu_calculate_bursts()` already handles arbitrary widths mathematically, and the foreground plane (`SYNC_FG`) path already uses unaligned widths without issue. However, I have a few concerns about completeness and potential side effects. **Verdict:** The change looks correct in principle but would benefit from addressing a couple of points before merging. --- --- Generated by Claude Code Patch Reviewer