From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: accel/amdxdna: Handle DETACH_DEBUG_BO through config_debug_bo path Date: Sun, 12 Apr 2026 14:24:28 +1000 Message-ID: In-Reply-To: <20260406211403.4011988-1-lizhi.hou@amd.com> References: <20260406211403.4011988-1-lizhi.hou@amd.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: accel/amdxdna: Handle DETACH_DEBUG_BO through config_debug_bo path Author: Lizhi Hou Patches: 3 Reviewed: 2026-04-12T14:24:28.973286 --- This is a single-patch fix for the `accel/amdxdna` driver. The bug is clear and the fix is correct: `DETACH_DEBUG_BO` commands submitted via `amdxdna_cmd_submit()` (at `aie2_ctx.c:883`) would hit the `default` case in `aie2_sched_job_run()` and return `-EINVAL`, because only `ATTACH_DEBUG_BO` was handled in the switch statement. The downstream handler `aie2_config_debug_bo()` already distinguishes between attach and detach via the opcode (line 1179 of `aie2_message.c`), so routing both opcodes to that function is the correct approach. The patch is minimal, well-targeted, and has an appropriate `Fixes:` tag. One minor style nit below, but functionally this looks good to merge. --- Generated by Claude Code Patch Reviewer