From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: gpu: nova: require little endian Date: Sun, 12 Apr 2026 14:07:45 +1000 Message-ID: In-Reply-To: <20260407-fix-kconfig-v2-1-6b4fb06c690c@nvidia.com> References: <20260407-fix-kconfig-v2-1-6b4fb06c690c@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: gpu: nova: require little endian Author: Eliot Courtney Patches: 7 Reviewed: 2026-04-12T14:07:45.623021 --- This is a single-patch series that adds `depends on !CPU_BIG_ENDIAN` to both `nova-core` and `nova-drm` Kconfig entries. The change is straightforward, well-motivated, and correct in intent: the nova driver code assumes little-endian byte ordering (e.g., directly interpreting GPU command queue bytes), and this makes that assumption explicit at the config level rather than leaving it implicit. The author notes that `RUST` transitively depends on `!CPU_BIG_ENDIAN`. Checking the current tree, this is *practically* true but not *technically guaranteed*: arm64 selects `HAVE_RUST` unconditionally, but arm64's `CPU_BIG_ENDIAN` currently depends on `BROKEN` (so it's effectively unreachable). The other arch that could theoretically enable both is RISC-V, but it doesn't define `CPU_BIG_ENDIAN` at all. So while the transitive dependency holds today through indirect means, adding the explicit `depends on !CPU_BIG_ENDIAN` is the right thing to do -- it documents the driver's actual requirement rather than relying on an accidental property of the Rust toolchain's arch support. **Verdict:** The patch is clean, minimal, and correct. No issues found. --- --- Generated by Claude Code Patch Reviewer