From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: qcom: Refactor GPU GX GDSC handling and IFPC behavior on A8x GPUs Date: Sun, 12 Apr 2026 13:46:54 +1000 Message-ID: In-Reply-To: <20260407-gfx-clk-fixes-v1-0-4bb5583a5054@oss.qualcomm.com> References: <20260407-gfx-clk-fixes-v1-0-4bb5583a5054@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: qcom: Refactor GPU GX GDSC handling and IFPC behavior on A8x GPUs Author: Taniya Das Patches: 17 Reviewed: 2026-04-12T13:46:54.677976 --- This series addresses two real problems with GX GDSC ownership and rail voting on A8x (Kaanapali) GPUs. The cover letter is well-written and clearly explains both problem statements and their solutions. The approach of using `synced_poweroff` as a gate for OS-side GX collapse is sound and follows the existing pattern used for CX PD in the recovery path. There are a few issues worth addressing: 1. **Missing `#else` stub in gdsc.h** (Patch 1) will cause build failures when `CONFIG_QCOM_GDSC` is not set. 2. **Patch 3 has broader scope than motivated** -- it changes behavior for all `use_rpm` clock controllers, not just gxclkctl. 3. **Unchecked `pm_runtime_get_sync()` return value** in Patch 6's `a6xx_gmu_gxpd_put()`. 4. **Ordering difference with a6xx_recover** in Patch 5, despite claiming to match that behavior. --- --- Generated by Claude Code Patch Reviewer