From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: arm64: dts: imx952: Describe Mali G310 GPU Date: Sun, 12 Apr 2026 14:13:24 +1000 Message-ID: In-Reply-To: <20260407-master-v3-1-5a05cea0c521@nxp.com> References: <20260407-master-v3-1-5a05cea0c521@nxp.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: arm64: dts: imx952: Describe Mali G310 GPU Author: Guangliu Ding Patches: 2 Reviewed: 2026-04-12T14:13:24.488598 --- This is a single patch (v3) adding a device tree description for the Mali G= 310 GPU on the i.MX952 SoC. The patch adds an OPP table and a GPU device no= de to `imx952.dtsi`, mirroring the existing GPU definition in `imx95.dtsi` = since both SoCs use the same Mali G310 GPU IP block. The patch is mostly straightforward and follows the existing imx95 GPU node= as a template. There are two items worth discussing =E2=80=94 one potentia= lly significant (missing clock) and one minor (missing cooling-cells). **Verdict**: Patch needs clarification on the missing `coregroup` clock, an= d the missing `#cooling-cells` should be explained or added. --- --- Generated by Claude Code Patch Reviewer