From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: backlight: add new max25014 backlight driver Date: Sun, 12 Apr 2026 13:25:20 +1000 Message-ID: In-Reply-To: <20260407-max25014-v8-0-14eac7ed673a@gocontroll.com> References: <20260407-max25014-v8-0-14eac7ed673a@gocontroll.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: backlight: add new max25014 backlight driver Author: Maud Spierings via B4 Relay Patches: 5 Reviewed: 2026-04-12T13:25:20.719247 --- This is a well-structured 4-patch series adding a new driver for the Maxim MAX25014 automotive backlight controller. The series is at v8 and has already received Reviewed-by tags from Rob Herring (binding) and Daniel Thompson (driver). The overall shape is good: binding first, then driver, then DTS consumers. However, there are several issues ranging from minor style nits to a few substantive problems that should be addressed. **Key concerns:** 1. Missing `#include ` in the driver 2. `of_match_ptr()` usage is discouraged for new drivers 3. Indentation bug in `max25014_parse_dt` 4. The `remove` function doesn't fully shut down the hardware 5. Kernel type conventions (`u32`/`u8` preferred over `uint32_t`/`uint8_t`) 6. Binary literals are unusual in kernel code --- --- Generated by Claude Code Patch Reviewer