From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: fbcon,fonts: Refactor framebuffer console rotation Date: Sun, 12 Apr 2026 13:55:01 +1000 Message-ID: In-Reply-To: <20260407092555.58816-1-tzimmermann@suse.de> References: <20260407092555.58816-1-tzimmermann@suse.de> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: fbcon,fonts: Refactor framebuffer console rotation Author: Thomas Zimmermann Patches: 12 Reviewed: 2026-04-12T13:55:01.507925 --- This is a well-structured 10-patch series from Thomas Zimmermann refactoring fbcon console rotation. It moves glyph and font rotation logic out of fbcon's private headers into the `lib/fonts/` library, creates clean public APIs, consolidates duplicated cursor mask code, and tidies up the rotation state in `fbcon_par`. The series begins with a genuine OOB fix (patch 1) and builds progressively through helper introduction, code movement, refactoring, and finally state reorganization. The overall design direction is sound: rotation is a property of fonts/glyphs, not fbcon internals, and belongs in `lib/fonts/`. The series is nicely decomposed into reviewable increments. However, **patch 7 introduces a correctness bug in the 180-degree rotation** for fonts whose width is not a multiple of 8 (i.e., most fonts). This needs to be fixed before merging. The series depends on a prerequisite series (the `font_data_t` / `vc_font` work) which explains why the patches don't apply to the current drm-next tree. --- --- Generated by Claude Code Patch Reviewer