From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: cdns-dsi: Replace deprecated UNIVERSAL_DEV_PM_OPS() Date: Sun, 12 Apr 2026 13:22:17 +1000 Message-ID: In-Reply-To: <20260407144142.1420354-2-ivitro@gmail.com> References: <20260407144142.1420354-2-ivitro@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/bridge: cdns-dsi: Replace deprecated UNIVERSAL_DEV_PM_OPS() Author: Vitor Soares Patches: 1 Reviewed: 2026-04-12T13:22:17.990676 --- This is a single well-motivated bugfix patch that replaces the deprecated `UNIVERSAL_DEV_PM_OPS()` macro with runtime-PM-only ops in the Cadence DSI bridge driver. The problem is clearly described: `UNIVERSAL_DEV_PM_OPS` registers the same callbacks for both system sleep *and* runtime PM, causing clocks to be disabled twice during system suspend (once via runtime PM, once via system sleep), triggering a clock framework warning. The fix is correct and appropriate. The driver already uses `pm_runtime_get_sync()` / `pm_runtime_put()` in its bridge `atomic_pre_enable` / `atomic_post_disable` callbacks (lines 736 and 631), so the DRM framework already manages the system suspend/resume path through the bridge lifecycle. Only the runtime PM callbacks are needed at the driver PM ops level. The patch has a Reviewed-by from Tomi Valkeinen and a Fixes tag with stable CC. It is in good shape for merging. **Verdict: Looks good.** --- Generated by Claude Code Patch Reviewer