public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dt-bindings: display: bridge: lt9211: Require data-lanes on DSI input ports
Date: Sun, 12 Apr 2026 13:19:34 +1000	[thread overview]
Message-ID: <review-overall-20260407203109.34302-1-marex@nabladev.com> (raw)
In-Reply-To: <20260407203109.34302-1-marex@nabladev.com>

Overall Series Review

Subject: dt-bindings: display: bridge: lt9211: Require data-lanes on DSI input ports
Author: Marek Vasut <marex@nabladev.com>
Patches: 2
Reviewed: 2026-04-12T13:19:34.040015

---

This is a single-patch v2 series adding `data-lanes` property definitions to the DSI input ports of the Lontium LT9211 devicetree binding. The pattern follows established conventions used by similar bridge bindings (e.g., `ti,sn65dsi83.yaml`). The switch from `$ref: /schemas/graph.yaml#/properties/port` to `$ref: /schemas/graph.yaml#/$defs/port-base` with `unevaluatedProperties: false` is the correct approach to allow additional endpoint properties.

The main concern is that the patch adds `required: - data-lanes` to port@0 and port@1, but these ports can serve multiple protocols (DSI, LVDS, or DPI). The `data-lanes` property is only meaningful for DSI, so unconditionally requiring it would make the binding reject valid LVDS/DPI devicetree descriptions. Notably, the ti,sn65dsi83 binding—which appears to be the template for this change—does **not** mark `data-lanes` as required, even though its ports are DSI-only.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-04-12  3:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-07 20:31 [PATCH v2] dt-bindings: display: bridge: lt9211: Require data-lanes on DSI input ports Marek Vasut
2026-04-08  7:35 ` Krzysztof Kozlowski
2026-04-12  3:19 ` Claude Code Review Bot [this message]
2026-04-12  3:19 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-20260407203109.34302-1-marex@nabladev.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox