From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: fsl-ldb: support downstream bridges in addition to panels Date: Sun, 12 Apr 2026 12:59:08 +1000 Message-ID: In-Reply-To: <20260408072802.3947600-1-xiaolei.wang@windriver.com> References: <20260408072802.3947600-1-xiaolei.wang@windriver.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/bridge: fsl-ldb: support downstream bridges in addition to pan= els Author: Xiaolei Wang Patches: 1 Reviewed: 2026-04-12T12:59:08.131190 --- This is a single-patch series that converts the fsl-ldb bridge driver from = panel-only support to supporting both panels and downstream bridges (e.g., = LVDS-to-HDMI converters). The approach =E2=80=94 replacing `of_drm_find_pan= el()` + `devm_drm_panel_bridge_add()` with `devm_drm_of_get_bridge()` =E2= =80=94 is a well-established pattern used across many DRM bridge drivers. T= he transformation is logically correct, the port selection logic is preserv= ed, and the DT binding already describes the output ports as accepting eith= er "panel or bridge". The patch will need a rebase: the current drm-next tree has an `nxp,enable-= termination-resistor` property check (added by commit range after `5c3cf372= 00bc`) inserted between the code blocks the patch modifies, which explains = the apply failure. After rebase, this should be a clean, straightforward ch= ange. **Verdict:** Looks good with minor nits. --- --- Generated by Claude Code Patch Reviewer